If you open a pull request that adds 1,009,257 lines across 6,755 commits, the *lenient* consequence should be that you are permanently banned from GitHub and all of your computers are fed into an industrial shredder.

https://github.com/oven-sh/bun/pull/30412

Rewrite Bun in Rust by Jarred-Sumner Β· Pull Request #30412 Β· oven-sh/bun

Blog post with details coming soon. It passes Bun's pre-existing test suite on all platforms (and fixes several memory leaks and flaky tests), the binary size shrinks by 3 MB - 8 MB, the benchm...

GitHub
@funnelfiasco Their project, their party.
@funnelfiasco the fact this got merged… I have no words
@funnelfiasco Interesting to see the pull request has been merged, but the README still states the project is written in zig. Seems updating the documentation didn't come into it! I don't know the project, nor do I think I would ever need it (thankfully).
@funnelfiasco
Give those computers proper homes.
And send the developer to the Salesforce mines.
@funnelfiasco ordinarily I would agree, but that's the author of Bun. So, they can make any kind of PR that want, and everyone else can make up their own mind about what that implies.
@swelljoe they can make any kind of PR they want, but they should feel shame for their choices.
@funnelfiasco shame requires a self-awareness that is not evidenced here.
@funnelfiasco it's free software, they don't owe me anything. 🀷
@swelljoe @funnelfiasco imprecise usage of the term "free" as I ponder the cost in tokens and how that translates to cost in energy usage and infrastructure impact.
@swelljoe @funnelfiasco To me the logical move for a complete rewrite with 0 relevance to the original other than surface compatibility (I guess??) would have been to open a new repository. If for nothing else, that every single open issue and MR is now void anyway.
@funnelfiasco Is that a major version change, right? Right???  

@funnelfiasco Inappropriate. Instead a fork should be created and offered for adoption. I would call it 'SloppyBun'.

Or 'SloppyBunbuns' if marketing wanted to keep things as cute as possible.

@funnelfiasco

https://github.com/oven-sh/bun/pull/30412#issuecomment-4466275519

> Cool but hoping the quality of the code is alright...

Fingers crossed, eh?

Rewrite Bun in Rust by Jarred-Sumner Β· Pull Request #30412 Β· oven-sh/bun

Blog post with details coming soon. It passes Bun's pre-existing test suite on all platforms (and fixes several memory leaks and flaky tests), the binary size shrinks by 3 MB - 8 MB, the benchm...

GitHub
@funnelfiasco insane how they add so much code but deleted just few thousands lines.. Is rust insanely verbose?
@madduci @funnelfiasco they didn't remove the old, and still currently used, code.