| Website | https://www.donmccurdy.com/ |
| https://twitter.com/donrmccurdy | |
| GitHub | http://github.com/donmccurdy/ |
@xor on etiquette, I find this guide from Google code review applies well to my GitHub projects. Particularly, clearly marking the optional and FYI comments:
https://google.github.io/eng-practices/review/reviewer/comments.html
If there are major issues I’ll usually post those first, and do a second round of review for smaller things later.
@robhawkes I like threads! I’m still learning this website but I think it’s considered best practice to mark only the first post in a thread as Public, and the rest as Unlisted.
At least in my iOS client (Toot) this can be set as the default.
@tojiro if you'd prefer to maintain .d.ts files by hand, that is no problem for developers using your library. But in my experience it's a lot more painful for you!
I wish TS provided automated tools to confirm that your .d.ts files match up with source .js files, but never found reliable ways to do that.
@tojiro very possible that I've missed something, but I thought that was how it was always done. See the microsoft/tsdoc library for example:
@tojiro the import/extension thing is very frustrating. Causes a lot of issues for Deno community. :(
That said, I *would* really encourage publishing compiled .js/.d.ts files to npm. I use microbundle to do that — it’s Rollup with opinionated default settings — and I don’t publish the source .ts files.
