I eventually chose 1password for reasons.

Really it was a choice between keepass and 1password, full OSS or the last company standing who seems to still do a good job (but some questionable sponsorships).

I liked everything about keepass but the fact that it was really login only, and I keep other things in the vault and templates are promised but haven't arrived yet.

I liked 1password for supporting all of the types of secret I want to store, even beyond logins... but having played a little I like the nested tags, the slick UX, and that it's multi-account and has an affordable family plan that could extend to the partners too (though some have 1password already and won't need to be granted access).

1password is the one for me, for at least the foreseeable future. perhaps by the time I need to look again keepass templates and UX improvements will have arrived.