Badly-read literary snobMar 4
When it comes to code:
* 0.5
19.2%
/ 2
80.8%
Poll ended at .
Show threadBadly-read literary snob
You have a constant that’s used in only one place. You
Add a comment to explain what it represents
25%
Assign it so it gets a name
75%
Poll ended at .
Mar 23 at 8:22amWeb
Show threadBadly-read literary snobMar 23
The stuff your program operates over are:
Entities
45.8%
Models
54.2%
Poll ended at .
Show threadBadly-read literary snobMar 24

```
if let result { return result.union(frame) }
else { return frame }
```

or

```
guard let result else { return frame }
return result.union(frame)
```

If else
50%
Guard
50%
Poll ended at .
Show threadBadly-read literary snobMar 25
In case you wonder: yes I’m taking these seriously
Show threadArianMar 24
@RosaCtrl i have no intuition about Swifts Syntax whatsoever. It's impossible to type a syntactically correct swift program by hand
Show threadBadly-read literary snobMar 24
@arianvp hey!
Show threadmlenMar 24

@RosaCtrl I prefer guards for the reasons described here: https://testing.googleblog.com/2017/06/code-health-reduce-nesting-reduce.html

The TotT series is a pretty good resource from the times people still cared.

Code Health: Reduce Nesting, Reduce Complexity

This is another post in our Code Health series. A version of this post originally appeared in Google bathrooms worldwide as a Google Testin...

Google Testing Blog
Show threadBadly-read literary snobMar 24
@mlen right, I often go with guards, but in this tiny snippet I think if is more obvious
Show threadsamir, an unknown quantityMar 24

@RosaCtrl ```
return (if let result { result } else { emptySet() }).union(frame)

Show threadBadly-read literary snob6d ago
@samir you would think that in Swift if is an expression! This makes me so mad
Show threadsamir, an unknown quantity6d ago
@RosaCtrl You have some kind of ternary condition operator, surely? Do ? and : work?
Show threadBadly-read literary snob6d ago
@samir yes, but then let doesn’t work
Show threadsamir, an unknown quantity6d ago
@RosaCtrl Grar.
Show threadTimMar 25
@RosaCtrl Not sure I'm parsing these. Swift? Something else? I can't make any sense of the second form at all.
Show threadBadly-read literary snobMar 25
@penryu Swift indeed
Show threadAndre Videla6d ago
@RosaCtrl result.map(union)?? frame
Show threadAndre Videla6d ago
@RosaCtrl wait the idiomatic way is frame?.union() isn't it
Show threadsamir, an unknown quantity6d ago
@Andrev @RosaCtrl Maybe (result ?? emptySet).union(frame) would work?
Show threadAndre Videla6d ago
@samir @RosaCtrl ah yes! I like this one
Show threadBadly-read literary snob6d ago
@Andrev @samir guys you rendered this poll useless 😭
Show threadsamir, an unknown quantity6d ago
@RosaCtrl @Andrev When presented with two options, always choose option three!
Show threadHécateMar 23
@RosaCtrl what's the difference? 😭
Show threadBadly-read literary snobMar 23
@hecate exactly. Just curious what’s the consensus
Show threadHécateMar 23
@RosaCtrl I put my business domain types in a folder called "Model" so I guess for me it's model :')
Show threadTimMar 23
@RosaCtrl Bits! 😃
Show threadBadly-read literary snobMar 23
@penryu what?
Show threadTimMar 23
@RosaCtrl My program operates on, and is composed of, bits!
Show threadBadly-read literary snobMar 23
@penryu that’s fake!
Show threadTimMar 23
@RosaCtrl FAKE?! Then all these bits I've been twiddling are imaginary?!
Show threadBadly-read literary snobMar 23
@penryu all of them!
Show threadNiklas    Mar 23

@RosaCtrl
I'd say a "Model" describes types of entities, while an "entity" is an instance of a model.

Example: a blog may have a "Post model" (in general).
One specific deployment of a blog may have 1000 "Post entities" (i.e. instances of the Post model).

If a model is backed by a database, I'd use the terms "entity", "record" and "row" synonymously.

Show threadkiniMar 23
@RosaCtrl "A constant that's used only in one place" like a magic string?
Show threadBadly-read literary snobMar 23
@kini yes, or a number
Show threadzarelMar 23
@RosaCtrl probably both a name and a comment if necessary
Show threadNicolas RinaudoMar 24
@RosaCtrl that really depends on whether the value as a more interesting semantic meaning than itself. 2, for example, is perfectly good when it's used to double a number. Not when it's the maximum number of retries for some operation.
Show threadzerologyMar 24

@RosaCtrl Depends.

If the constant is, say, „This is not a number.“, then keep the string, it‘s self explaining. If the constant is, say, 299792458, give it a name like speedOfLight, as I heard that people exist who don‘t recognize that number.

Show threadBadly-read literary snobMar 24
@zerology 😂