Mastodawn

iliana (quiet main)Apr 14, 2018

*blink*

https://github.com/github/linguist/issues/3988#issuecomment-381356302

Classify Cargo.lock as a generated file · Issue #3988 · github/linguist

In binary Rust crates, the expectation is to commit your Cargo.lock file along with Cargo.toml and other files. I've not seen a case where the Cargo.lock file is hand-generated, and it often co...

Show thread

bb010g Apr 14, 2018

@iliana I wonder if that means that GitHub hasn't really worked with Rust too heavily internally. They'd fix it if it bugged them.

Show thread

bb010g Apr 14, 2018

@iliana Anyhow, it didn't look too bad, so I put in a PR and the tests pass. https://github.com/github/linguist/pull/4100

Teach Generated about Cargo lock files by bb010g · Pull Request #4100 · github/linguist

This PR teaches linguist.generated.Generated about Cargo.lock files. Resolves #3988. Checklist: I am associating a language (TOML) with a new filename (Cargo.lock) . The new filename is used in...

Show thread

bb010g

Good news, everyone!

https://github.com/github/linguist/pull/4100

For all you #rust folk, GitHub should be properly treating Cargo.lock files as generated TOML soon, keeping them out of your automatic diff display and providing highlighting when you do look at them.

Teach Generated about Cargo lock files by bb010g · Pull Request #4100 · github/linguist

This PR teaches linguist.generated.Generated about Cargo.lock files. Resolves #3988. Checklist: I am associating a language (TOML) with a new filename (Cargo.lock) . The new filename is used in...