David Smith1d ago

Defense in depth:

1) Write tests for the new functionality

Don’t trust that

2) Adopt the new functionality in existing API so the tests for that also get coverage

Still don’t trust that

3) Grab another team’s project, replace all their versions of similar stuff with mine even where it doesn’t make sense to, make sure their tests also still pass

STILL don’t trust that

4) Install it on my work laptop and use it for a while

I still don’t trust it but I’ve run out of test ideas so, merged 🤞

Show threadJames Savage1d ago
@Catfish_Man honestly deploying to production for multiple years doesn’t prove anything either. I just don’t trust.
Show threadDavid Smith1d ago
@axiixc and the thing I wrote is, essentially, strcmp. So just a bit load bearing 😅😅😅
Show threadJames Savage
@Catfish_Man just don’t go rewriting malloc and you’ll be fine 🤪
Mar 27 at 2:16amWeb
Show threadDavid Smith1d ago
@axiixc last time I added a sizing fast path to swift_slowAlloc it broke ASAN in completely impossible ways, so yeah >.<