To
#NVDASR community: please, PLEASE don't just use an AI system to submit pull requests:
https://github.com/nvaccess/nvda/pull/197871/
In recent days, several NVDA screen reader pull requests were closed because NV Access realized that these PR's were written by AI without filling out the NVDA PR template:
https://github.com/nvaccess/nvda/pull/19774https://github.com/nvaccess/nvda/pull/19775https://github.com/nvaccess/nvda/pull/197762/
fix: guard oldTracker.pluralTimeout before comparison in makeMergedTrackerIfPossible by seang1121 · Pull Request #19774 · nvaccess/nvda
Fixes #19620
Summary
In makeMergedTrackerIfPossible, the pluralization branch checked newTracker.pluralTimeout is not None before using it, but did not apply the same guard to oldTracker.pluralTime...
Pull request templates exist for a number of reasons, including communicating expectations by the organization/project and to help pull request writers (humans or machines) organize thoughts and information in a structured way. In organizatoinal communication space, this means when an AI generates a PR and the template content, it is communicating the knowledge gathered by an organization that can conflict with expectations from another organization. 3/
Joseph Lee