Michael Stapelberg 🐧🐹😺Feb 6

PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?

Like https://github.com/i3/i3/pull/6564 for example

Such diffs will be applied by patch(1) (also git-am(1)) as part of the code change!

This is how a sleep(1) made it into i3 4.25-2 in Debian unstable.

Show threadMelissa ​

@zekjur i wonder if this works when the diff is hidden within a markdown comment <!— like this —>

That could be an extremely bad vulnerability

Feb 6 at 9:10amWeb
Show threadfunbaker; Je suis AntifaFeb 6
@codecat @zekjur this is a HTML comment.
Show threadMelissa ​Feb 6
@funbaker yes those work in markdown
Show threadМя ��Feb 6

@funbaker ...and markdown is usually superset of HTML

@codecat @zekjur

Show threadfunbaker; Je suis AntifaFeb 6
@mo @codecat @zekjur it isn't, but it can afaik inline HTML
Show threaduwu1baFeb 6
@mo @funbaker @codecat @zekjur or more like html just does what markdown in it's default specification can't.

implementing markdown parser and not doing html would be painful