mx alex tax1a - 2020 (6)
what we learned yesterday from the cloudflare thing is that cloudflare's people regularly use throwing functions without corresponding catches immediately surrounding them, apparently because using the result or option type is too much work, and, okay, i guess
Nov 21 at 1:34amWeb
Show threadHuldraNov 21
@atax1a I read their postmortem, and was genuinely baffled by how a major internet company would allow that to be pushed to prod. It’s a “I did a first pass review of your PR in 5 minutes while I was eating lunch and I’m not letting you merge that” level issue.
Show threadmx alex tax1a - 2020 (6)Nov 21
@kurgarru i mean we're not a rust programmer or anything but when we have the choice to use an option type or a throwing function we go for the option type 99.975% of the time
Show threadmx alex tax1a - 2020 (6)Nov 21
@kurgarru and when we don't have a choice and have to use a throwing function we reflexively try/catch around as little as possible, because jfc
Show threadHuldraNov 21
@atax1a yeah, just based on the snippet they posted, it doesn’t seem like there’s a justification for the unwrap call. The only explanation I have for pushing something that stupid is AI slop shenanigans, or some truly heinous code review/linting practices.