Christiaan Kras

Dear #perl @Perl folks that use Dist::Zilla. I'm trying to release a new version of Validation::Class but I'm stuck with dzil release. All tests pass, files are modified but for some reason the modifications aren't committed to Git?

To clarify, my Git index is clean before running the release command.

I've got no clue on how to proceed here as I barely know how Dist::Zilla works.

https://github.com/Htbaa/Validation-Class

#dzil

GitHub - Htbaa/Validation-Class

Contribute to Htbaa/Validation-Class development by creating an account on GitHub.

GitHub
Mar 27, 2023 at 8:36pmWeb
Show threadChristiaan KrasMar 27, 2023

@Perl or does it expect me to commit the changes before Git/check etc. run? There's a moment to do that when it asks if I want to proceed.

"Before a release, check that the repo is in a clean state (you have committed your changes)."

This is what it says in the documentation of the Git plug-in. But does that relate to changes *before* running release or the moment it asks me to proceed?

Show threadChristiaan KrasMar 27, 2023
@Perl Well, guess I had to commit the changes myself. Wish it would tell me that on the CLI though :-). Managed to upload the release, yay!
Show threaddakkarMar 28, 2023
@Htbaa I'm late, but maybe I can still be useful:
if you generate/modify files in your working copy (and not just inside the build directory), you probably want Dist::Zilla::Plugin::Git::Commit to automate the commit for you; also, you have to make sure it's listed (in dist.ini) after whatever plugin does the generation/modification.

@Perl
Dist::Zilla::Plugin::Git::Commit - Commit dirty files - metacpan.org

Commit dirty files

Show threadChristiaan KrasMar 28, 2023
@dakkar @Perl Cheers. I can see the value in it not auto committing. Don't have to release often for this module so I'm undecided in what to do with it. I know now I need to manually commit those changes. Let's hope I remember it for the next time :-).
Show threaddakkarMar 28, 2023
@Htbaa yeah, dzil can't know if you meant to touch those files, or if it was an accident ☺ with the Git::Commit plugin, you're saying "I meant it, save these changes"

@Perl
Show threaddavehodgMar 27, 2023
@Htbaa @Perl dzil has nothing to do with git, right?
Show threadChristiaan KrasMar 27, 2023

@davehodg @Perl I guess not, but it's using a Git plug-in to update some files and automatise the release. https://metacpan.org/pod/Dist::Zilla::Plugin::Git

Last year I did a release as well and had no issues. But in the meantime brew on my Mac updated to Perl 5.36 so had to reinstall all dependencies.

Dist::Zilla::Plugin::Git - Update your git repository after release - metacpan.org

Update your git repository after release

Show threadTimothy LeggeMar 27, 2023
@Htbaa @Perl do a dzil test before the release and then commit the Makefile.PL README etc. Before the dzil release
Show threadChristiaan KrasMar 27, 2023
@timlegge @Perl I indeed had to manually commit the changes before letting the Git plug-in continue.
Show threadTimothy LeggeMar 27, 2023
@Htbaa @Perl I end up doing "dzil test" and commiting the changes to the repo soon after I make a release so I don't have to think about it next time
Show threadAndrew Hewus FreshMar 27, 2023

@Htbaa
There is a Dist::Zilla plugin to commit for you.
@Perl

https://metacpan.org/pod/Dist::Zilla::Plugin::Git::Commit

Dist::Zilla::Plugin::Git::Commit - Commit dirty files - metacpan.org

Commit dirty files