How would you recommend going about opening a PR on an open source codebase, for 5 months or so work reviving a stale PR, continuing the work, and adding a whole new testing side to allow for running MIRI on some C bindings? bcs I kinda just hit go on the dang thing
lofty!
- 2 Followers
- 21 Following
- 33 Posts
@beepster4096 since miri only has limited support for FFI bindings, and doesn't track behaviour in the foreign code, and because the OS on the embedded device that I'm trying to work with requires a reasonable amount of setup of background services, I implemented all of the 'extern "C" fn' methods in Rust, which was pretty good for catching some bugs!
https://github.com/flipperzero-rs/flipperzero-rs/pull/261 this is the pr
Rebase GUI APIs, bring up to date, and test with MIRI by loftyinclination · Pull Request #261 · flipperzero-rs/flipperzero-rs
This is a continuation of the work in #250 and in #29, rebasing the latter onto the former and continuing the work of creating some useful GUI bindings. Differences from the GUI PR; Callbacks have...
(i have previously opened a PR for just the MIRI side of things, which had comments about the extended work that was going on, and left comments on some of my findings on the stale PR, so hopefully it wasnt a _complete_ surprise)
@blyxyas hey would you be able to share that cat emoticon? super cute and I want to use it myself!!
@iliana i've been thinking about a subghz radio chip, like the flipper has