Loony division-sowing anti-FSF nu-dev mastoclowns vs. BlueSky!
A figure of speech I came across once comes to mind. It goes something like “may god put the fire out with a rainfall of gasoline”.

It is always a risky move going from the safe echo chamber to the real world though. It always brings a shock to the system.

Blocking work instead of comms.
And being open about it.
How obnoxious!

We already knew it was from mastoclowns, for mastoclowns.
The details and which “e-celebs” are involved is immaterial.
No one relevant (or merely sane) cared, cares, or will ever care about that scene’s rage-circlejerk choice of the day.

Regarding Cargo.lock, the recommendation always was to include it in version control for application/binary crates, but not library ones. But tendencies changed over time to include it even for libraries. If a rust-toolchain file is tracked by version control, and is pinned to a specific stable release, then Cargo.lock should definitely be tracked too [1][2].

It’s strictly more information tracked, so there is no logical reason not to include it. There was this concern about people not being aware of –locked not being the default behaviour of cargo install, giving a false sense of security/reliability/reproducibility. But “false sense” is never a good technical argument in my book.

Anyway, your crate is an application/binary one. And if you were to not change the “*” dependency version requirement, then it is almost guaranteed that building your crate will break in the future without tracking Cargo.lock ;)

• Don’t use “*” dep version requirements.
• Add Cargo.lock to version control.
• Why read to string if you’re going to base64-encode and use Vec<u8> later anyway?

Here is an originally random list (using cargo tree --prefix=depth) with some very loose logical grouping. Wide-scoped and well-known crates removed (some remaining are probably still known by most).

mime data-encoding percent-encoding textwrap unescape unicode-width scraper arrayvec bimap bstr enum-iterator os_str_bytes pretty_assertions paste clap_complete console indicatif shlex lz4_flex mpeg2ts roxmltree speedy aes base64 hex cbc sha1 sha2 rsa reverse_geocoder trust-dns-resolver signal-hook signal-hook-tokio blocking fs2 semver snmalloc-rs

My quick notes which are tailored to beginners:

Use Option::ok_or_else() and Result::map_err() instead of let … else.

• let … else didn’t always exist. And you might find that some old timers are slightly triggered by it.
• Functional style is generally preferred, as long as it doesn’t effectively become a code obfuscater, like over-using Options as iterators (yes Options are iterators).
• Familiarize yourself with the ? operator and the Try trait

Type inference and generic params

let headers: HashMap = header_pairs .iter() .map(|line| line.split_once(":").unwrap()) .map(|(k, v)| (k.trim().to_string(), v.trim().to_string())) .collect();

(Borken sanitization will probably butcher this code, good thing the problem will be gone in Lemmy 0.19)

Three tips here:

You don’t need to annotate the type here because it can be inferred since headers will be returned as a struct field, the type of which is already known.

In this pattern, you should know that you can provide the collected type as a generic param to collect() itself. That may prove useful in other scenarios.

You should know that you can collect to a Result/Option if the iterator items are Results/Options. So that .unwrap() is not an ergonomic necessity 😉

Minor point

• Use .into() or .to_owned() for &str => String conversions.
  • Again, some pre-specialization old timers may get slightly triggered by it.

make good use of the crate echo system

• It’s important to make good use of the crate echo system, and talking to people is important in doing that correctly and efficiently.
  • This post is a good start.
  • More specifically, the http crate is the compatibility layer used HTTP rust implementations. Check it out and maybe incorporate it into your experimental/educational code.

Alright, I will stop myself here.

Blog announcement.

github.com/LemmyNet/lemmy/pull/4024

Broken input sanitization probably.

Issue will thankfully no longer exist in the next lemmy release.