ALLIE ❤ HARTNew user: “Um hello is there a good reason why my bio can't be more characters??”
Me, dead serious: “No.”
Me, dead serious: “No.”
Oracle(tm) e-Business Social 🎃@u2764 no good reason why you can't post more than 500 characters at a time either. if you have your own instance you can hack those limits :)
@KitRedgrave or if you're on Mastodon CE you can set the environment variable I added ;)
@u2764 soon enough :)
Moved: -> @@KitRedgrave @u2764 we should add a bio-length environment variable in CE.
@shel @KitRedgrave Or just make it the same as toot-length
@u2764 @KitRedgrave where the hell is the bio code... is it not called bio??? i can't even see it in the view for profiles... ugh...
@shel @KitRedgrave search for 160 lol
@KitRedgrave @shel (use the GitHub "this repository" search is what i'd do)
@u2764 to reference the variable it's just { post-length } right?
@u2764 or do i need to import the variable?
@shel Rails.x.config.max_length i believe
@shel inside `#{}` in you're in a string iirc
@u2764 so I should write `#{ Rails.x.config.max_length }` each time when the number 160 appears?
@shel Yes (I'm assuming the localization files are on the rails side and not javascripts?)
@u2764 yeah I'm not modifying the locales just the settings right now
@shel Sorry it's Rails.config.x.max_chars the x cones after config. So if you're talking like this:
validates :note, length: { maximum: 160 }, if: 'local?'
should be this:
validates :note, length: { maximum: Rails.config.x.max_chars }, if: 'local?'
@u2764 Cool. the branch feature-biolength I think should now have it so your bio length is the same as post length, although the text "maximum 160" is still there. I'm at work so I can't test it in vagrant but if you already have a CE vagrant box up you're free to pull feature-biolength and see if it works
@shel I'm gonna fix it up and then send a PR if that's ok~
@shel wow i gave you the wrong variable name lol. fixing~
@shel um. somebody broke the frontend. um.
@shel it's not loading the javascripts and i don't know why. i'm just on master
@shel i had to update rails and stuff… maybe it's just a problem on my end… but anyway i can't test this either 😅
@u2764
us: *forks mastodon*
us: *immediately breaks mastodon*
I know that @ninjawedding 's instance is running CE on master? (the latest commit on master was fixes they had made to get it running) Maybe they can help
@shel I actually don't need the frontend to test this so I'm gonna see if the skin loads properly and if so I should still be able to test
@shel I sent you a PR. We need to do a localization update at some point which makes the localization files read the max_chars variable for both bio length and post length because right now it's still 160/500 in all the descriptions lol
@u2764 yeah... just... it's not DRY >_>
i guess i could clone the repo, open all the locales in a fancy text editor, and do a Find/Replace For All Files In Session?
🍂@shel @u2764 I did have to move around some newly introduced components, and there was an issue in the way max_chars was bound in the compose form. I don't recall the frontend *never* loading, though.
Maybe Rails is getting mixed up with old versions of code?
rails assets:clobber assets:precompile will remove all the old bits.
Maybe Rails is getting mixed up with old versions of code?
rails assets:clobber assets:precompile will remove all the old bits.
@ninjawedding @shel Sprockets just isn't connecting things properly as far as I can tell so this might be it