Bram 🦝Jul 22, 2017

#programming

I find it ironic that github PR, that are supposed to be here to help collaboration are actually very individualistic in some way.

It really put the burden on the submitter instead on of the group because on how single "threaded" it is.

I would really like to be able to make proposition on the PR as suggestions for the submitter or for the group instead on only having review possibilities or pushing directly on they PR.

PR should be a discussion place, not a submission place.

Show threadbraulioJul 22, 2017
@bram why do you think it is not a discussion place? I find it easy to have discussions there (i.e being able to "cite" code is cool). That doesn't mean that project leaders are going to accept that discussion always, of course
Show threadBram 🦝Jul 22, 2017

@braulio a discussion with code, not only words, I can't easily suggest a code modification within another git branch (or I can do a PR of a PR but that' super clumsy), same for other member of the project, so it ends up only being "words" discussion while it should be a "code" discussion.

I very often just want to *propose* another (or a lot of other) commits to this PR, but my only solutions are:
- PR of PR (sucks)
- pushing directly on the branch, which can diplomatically sucks

Show threadBram 🦝Jul 22, 2017

@braulio and git is totally fitted for that, that's just the API that sucks.

So, in the end, most of the time all the burden ends up on the submitter and the receiver ack as some king of "client" that just says "yes/no/change that" instead of programming with the submitter and I think that this totally sucks, I don't want to have this position.

Show threadbraulio
@bram ok I see what you mean now. In the cases I've found, pointing to lines of code and suggesting (you can write code in the github comments too) changes was enough for small objections. It's true that this doesn't scale for bigger objections
Jul 22, 2017 at 10:01pmWeb
Show threadBram 🦝Jul 22, 2017
@braulio for me it's even more being able to work together as a group and not someone having to work alone for others.