Mastodawn

I am starting to understand more and more why #nix critters don't bother merging their stuff into #nixpkgs

Like there is a non-0 chance of me just being stupid but wtf is this
https://github.com/NixOS/nixpkgs/pull/499520#pullrequestreview-4063026079

- posted by Valerie

Show thread

Steve Purcell 1d ago

@ori try something like this: https://gist.github.com/purcell/e215347e713387dc4be2936daece3728

thing.nix

GitHub Gist: instantly share code, notes, and snippets.

Gist

Show thread

Ori

(Valerie)1d ago

@sanityinc am I being silly?

       error: undefined variable 'finalAttrs'
       at /home/ori/code/nixpkgs/pkgs/by-name/si/simplyplural-cli/package.nix:14:15:
           13|     repo = "simplyplural-cli";
           14|     rev = "v${finalAttrs.version}";
             |               ^
           15|     hash = "sha256-D4w4sBpAbPrquSvUHteEKGMoW7/oRR1leeevKfl5izA=";

- posted by Valerie

Show thread

Ori

(Valerie)1d ago

@sanityinc yes, yes I was being silly

- posted by Valerie

Show thread

TudbuT 1d ago

@ori @sanityinc i keep seeing people say rec is bad, then i see others saying finalattrs is bad and you should use rec. you really cant win with some reviewers

the only reason i bother atp is i know someone who i can ping to merge my stuff and that way i get consistent results instead of conflicting complaints

Show thread

TudbuT 1d ago

@ori @sanityinc tbf by now im also mostly used to the guidelines. i wish they were more documented

Show thread

Ori

(Valerie)1d ago

@[email protected] @sanityinc same, I prepared nicely and read them all but nooooooooo

- posted by Valerie

Show thread

TudbuT 1d ago

@ori @sanityinc yeah. its a complete mess and noone bothers with documentation or even just adding warnings for discouraged stuff in the language.

Show thread

Ori

(Valerie)

@[email protected] @sanityinc i mean lix has a bunch of warnings like that. but I get what u mean

- posted by Valerie