Ian RogersMar 17
I've been helping the team that have brought up https://sashiko.dev/ for AI generated LKML reviews. It's really impressive to see the wider set of issues that the AI reviews can bring up, and this will help with the quality of code in the Linux code base. #sashiko_dev #linux
Sashiko

Show threadAlex BradburyMar 27

@irogers this is really neat! I started playing with it to see how well an open weight model like Kimi K2.5 does on the included benchmarks.

Is the team looking at introducing additional tools (static analysis, clang-format, even a built kernel binary + qemu + debugger?) as part of the process?

Show threadIan RogersMar 27
@asb So sashiko uses prompts and with the patches the AI needs to answer questions like what locks are held by callers of this function? Most tools like this end up falling back on grep a lot. There is semcode integration as semcode allows comparisons between git branches and to answer questions like what calls a function through use of TreeSitter. Clang-analyzer could be a replacement to TreeSitter but I have questions about how this like ifdefs are handled.
Show threadAlex BradburyApr 4
@irogers I was thinking more static analysis or shell-based tools for poking a live system, running a compiler etc. Maybe it's different for kernel reviews, but mapping to what I'd find useful for LLVM reviews, if I were trying to be the most helpful reviewer possible I think I'd want a build of the before/after of the patch, when I think there's a bug I'd try to write an input that exhibits it so I can feed it back to the author etc.
Show threadIan Rogers
@asb I know from vibe choosing that this is possible. I've seen Gemini write a patch, write a test. Build and run the test, insert extra printf debugging...
Apr 4 at 7:28pmWeb
Show threadAlex BradburyApr 4
@irogers absolutely. Sashiko for now is exposing only a very limited set of tools https://github.com/sashiko-dev/sashiko/blob/896718ae10058713059d17aec9fef57d370270f0/src/worker/tools.rs which probably makes a lot of sense to keep things focused initially. But I think there is scope in the future for adding more prompts + exposed tools in areas where actually "kicking the tires" as part of the review might be helpful.
Show threadIan RogersApr 4
@asb yeah. I believe syzkaller has 1000s of open issues. There's lots of scope to automate and make things better. Unfortunately dealing with lkml can be hard work.