Kees CookMar 19

RE: https://fedi.lwn.net/@lwn/116239303710146388

And when you make changes to 20,000 kmalloc calls, you start getting CCed on a LOT of patches since you touched "neighboring code" recently. 😭

Show threadJani NikulaMar 19
@kees I'm eagerly waiting for your upcoming patches to get_maintainer.pl next. 😉
Show threadljsMar 20

@jani @kees it should default to showing maintainers and reviewers only. The git stuff is really silly and unhelpful.

Maybe if you run it on a patch with tags add those people too...

Show threadJani NikulaMar 20

@ljs @kees

Yeah, returning stuff from git history should only be a fallback for files without maintainers. I get my fair share of these Cc's and I'm always like WTF why am I included.

IMO it should also only include the most specific maintainers by default. If you have the maintainer for file foo/bar/baz, don't include the maintainer for foo/bar or foo.

Show threadJani Nikula

@ljs @kees

Oh, and the primary reason I only whine and moan here instead of sending patches is that the damn thing is written in Perl. Plus I don't want to get Cc'd for patches touching get_maintainer.pl in the future. No wait. 😉

Mar 20 at 12:12pmWeb
Show threadljsMar 20
@jani @kees yeah I'm not really keen on fiddling with perl either... I normally put my money where my mouth is on whines re: kernel but in this case, no :))