such0299Feedback for first Rust Program
Welcome to Rust, I hope you enjoyed learning and using it :)
One major advice would be to run cargo clippy, which gives a lot of helpful hints. Apart from that I also have some feedback.
These comments should be doc-comments (///) so that cargo doc picks them up.
Not saying that your return type is bad, but in general you might be interested in crates thiserror and anyhow that simplify error handling.
Duration::from_mins(1) would be much more readable.
You should almost never panic. Your function already returns a Result<>, so you should be using that for error handling.
70 } else { 71 // HTTP Status is not 200Not Rust specific, but usually I recommend to handle errors first, and return from the function early. This way you reduce cognitive load on the reader, and reduce nesting of if-blocks.
150 let mut parts = line.splitn(2, '\t');There’s a convenient method to split in two substrings that you could have used:
let (mac_address, vendor_organization) = line.split_once('\t').unwrap_or(("", "")); 166 vendor_oui_data.vendor_address += line 167 .trim() 168 .split(' ') 169 .filter(|s| !s.is_empty()) 170 .collect::<Vec<_>>() 171 .join(" ") 172 .as_str();I would probably write a regular expression that replaces all contiguous whitespace with a single space instead.
173 vendor_oui_data.vendor_address.push('\n');Aren’t you trimming this new line off in line 181?
181 vendor_oui_data.vendor_address = vendor_oui_data.vendor_address.trim().to_string();This is somewhat inefficient, since you’ll be allocating and copying your string here.
Hello and Thank You :D Rust really intrigues me so i really want to explore more about Rust
cargo clippy I’ll look for Clippy
These comments should be doc-comments (///) so that cargo doc picks them up. I see, i guess i skimmed the Rust Docs :D
but in general you might be interested in crates thiserror and anyhow that simplify error handling. Still, Rust Error Handling and Rust in General is still a big black box for me yet to be unveiled :D, why do i need crates for error handling? But I’ll look into it. Still can’t quite grasp the concept of Rust
Duration::from_mins(1) would be much more readable. Nice info, never knew this existed before, because i found it in some tutorial that timeout need something in Duration.
You should almost never panic. Your function already returns a Result<>, so you should be using that for error handling. Still figuring how to handle error, but just like what the others say, panic should never occurred, and always return the error
Not Rust specific, but usually I recommend to handle errors first, and return from the function early. This way you reduce cognitive load on the reader, and reduce nesting of if-blocks. That’s actually correct, thank you for your input, i always ended with nasty nested if before because of this. Never thought about it before XD
Thank you for your input. I’ll refactor my code
Rust Error Handling and Rust in General is still a big black box for me yet to be unveiled :D
Conceptually, error handling in Rust is incredibly simple: if a function can fail, its return type is an enum of either the result of the function (in case of success) or a description of the error that happened. This enum is called Result. See:
- doc.rust-lang.org/…/ch09-02-recoverable-errors-wi…
- doc.rust-lang.org/…/early_returns.html
- doc.rust-lang.org/…/ch02-00-guessing-game-tutoria…
why do i need crates for error handling?
You don’t. You can 100% handle errors without any additional dependencies, and probably you should be doing that in the beginning. The crates simply add a little bit of syntactic sugar to simplify some boilerplate that you’ll have to start writing as soon as your error handling gets sufficiently complex.