aevaone of the more useful things I realized at some point for how to be a good code reviewer is "that's not how I'd do it" is not constructive feedback and is not a valid reason to request a change, and if you can't think of an actual good reason to block a review, you can save a lot of time for everybody involved by just chilling out about it
side thought: I don't get people who are adverse to reading code written by other people. how on earth did you people learn to program?
Allan Chow@aeva it's ok I'll just read code generated by AI then.
@grumpasaurus I said "written by people". I was very careful to write "written by people".
@aeva I think that's the rub right? Because I think it's very that people who simply don't want to read other people's PRS are likely the people who will simply commit things written by AI that they haven't even bothered to review
@grumpasaurus I don't know that I've had the displeasure of having to review an entirely stochastic code submission yet, but my current policy for my hobby projects is I reserve the right to report people as spam, block them, and/or be mean to them as necessary. If or when that situation eventually comes up at work, my current feelings are that I'm paid enough to conduct myself with professionalism and dignity when working with clients.