aevaone of the more useful things I realized at some point for how to be a good code reviewer is "that's not how I'd do it" is not constructive feedback and is not a valid reason to request a change, and if you can't think of an actual good reason to block a review, you can save a lot of time for everybody involved by just chilling out about it
Asta [AMP]@aeva it was not until quite recently, in the grand scheme of things, that I had positive PR experiences that didn't involve pushback from a senior male employee that boiled down to (or was plainly stated as) this.
At my current job, in fact, I had a shit ton of anxiety about PRs for probably the first six months due to numerous, numerous experiences where a PR was used to gatekeep and delay my contributions. Especially when I could look at other PRs where male colleagues were doing exactly the same thing and were approved without even a comment on it.
I'm not as anxious now specifically because I've received good feedback at my current job (not coincidentally, none of it was ever shaped like this).
At my current job, in fact, I had a shit ton of anxiety about PRs for probably the first six months due to numerous, numerous experiences where a PR was used to gatekeep and delay my contributions. Especially when I could look at other PRs where male colleagues were doing exactly the same thing and were approved without even a comment on it.
I'm not as anxious now specifically because I've received good feedback at my current job (not coincidentally, none of it was ever shaped like this).
@aud my last job (about 10 years ago) I worked at a place like that and they tracked individual "velocity" as a performance review metric. every single thing I'd try to submit took a week to get through review no matter how trivial.
@aud that team also did a thing where the entire team votes on the "point" score of a given ticket, and mine always got voted low for some reason 🙄
d@nny disc@ mc²@hipsterelectron @aud it was a very upsetting and confusing place. At the time I felt like I got along with the people on my team and they certainly seemed friendly. I'm not even sure they realized they were doing it.
@hipsterelectron @aud unexamined prejudice and cognitive dissonance makes people do strange and awful things sometimes. (and sometimes people are just twofaced jerks idk)