aevaone of the more useful things I realized at some point for how to be a good code reviewer is "that's not how I'd do it" is not constructive feedback and is not a valid reason to request a change, and if you can't think of an actual good reason to block a review, you can save a lot of time for everybody involved by just chilling out about it
Asta [AMP]@aeva it was not until quite recently, in the grand scheme of things, that I had positive PR experiences that didn't involve pushback from a senior male employee that boiled down to (or was plainly stated as) this.
At my current job, in fact, I had a shit ton of anxiety about PRs for probably the first six months due to numerous, numerous experiences where a PR was used to gatekeep and delay my contributions. Especially when I could look at other PRs where male colleagues were doing exactly the same thing and were approved without even a comment on it.
I'm not as anxious now specifically because I've received good feedback at my current job (not coincidentally, none of it was ever shaped like this).
At my current job, in fact, I had a shit ton of anxiety about PRs for probably the first six months due to numerous, numerous experiences where a PR was used to gatekeep and delay my contributions. Especially when I could look at other PRs where male colleagues were doing exactly the same thing and were approved without even a comment on it.
I'm not as anxious now specifically because I've received good feedback at my current job (not coincidentally, none of it was ever shaped like this).
@aeva all my PRs, magically delayed! Either review just somehow takes longer to get around to and/or it includes trivial matters not grounded in anything except "I would have done this differently"... or sometimes with made up standards. Or I "committed" things incorrectly and should rewrite my entire branch. And...
yeah. yeah. oooooh. still quite mad about that, actually. Feeling my blood pressure rise.
yeah. yeah. oooooh. still quite mad about that, actually. Feeling my blood pressure rise.
unable to decrypt message@aud @aeva Ah, but might this possibly break this tiny thing that hypothetically someone might have used once 10 years ago even though the only way anyone would find out it exists would be by reading this source code? I guess we have to bend over backwards to verify this hypothetical person won't be upset if we change this. Yeah so what that people have complaining about the thing for years, we have to think about the hypothetical guy who might want it to be broken.