GD2
Fernando F. ManceraThe kernel patch series removing IPV6=m is out! I am quite happy about it and I hope I did not mess up :)
A lot of people were CC'ed, sorry about the noise ^^
It seems I messed up. fs_initcall() is not good enough as under certain situations there might be a race condition when booting up.
Replacing it with device_initcall() seems good enough.
One thing I do not understand is why this doesn't happen on my environment but it does happen on virtme-ng..
Marcos Paulo de Souza@ffmancera doesnt 9pfs setups network early, before calling init, making it fail this way?
That would also depend on how you invoke virtme-ng, I'm just guessing here :)
@ffmancera please tell us your findings :)
@mpdesouza So in essence, this seems a race condition as after booting several times on my libvirt environment I managed to catch it.
I think it is related to addrconf checking on loopback or some other uninitialized device..
After looking at the code using device_initcall() makes more sense.
Petr Tesařík103 files changed, 310 insertions(+), 795 deletions(-)
@ffmancera @vbabka Code is a liability, Code’s capabilities are assets, but only as long as they are useful.
Shlee fooled around &@ffmancera any performance differences?
@shlee I would probably need to run some benchmark per subsystem affected but in essence dropping indirect calls and the extra overheard is a good thing performance wise :)
T_X@ffmancera have you checked with the #OpenWrt people? One thing that would come to my mind: We used to have embedded devices with separate kernel and rootfs partitions, where the kernel partition would have a fixed, limited size. There it would seem useful to be able to build as much as kernel modules as possible. We've had that issue before, not being able to update the kernel due to limited size.
But I'm not 100% sure if that is still the case or which (old?) devices that would affect exactly.
But I'm not 100% sure if that is still the case or which (old?) devices that would affect exactly.
@T_X AFAIU, openWRT is using CONFIG_IPV6=y by default since these three commits.
https://github.com/openwrt/openwrt/commit/0c8f0186d58468024db96a5ab0ca36a4d400d408
https://github.com/openwrt/openwrt/commit/836d462b10e82a3314e62bb5d15a1632e5786271
https://github.com/openwrt/openwrt/commit/33beafa8d88e51907acba6fdece5a35f509934df
James Just James@ffmancera I know you like this but I think it is a bad idea for users.
@purpleidea Why? Other than increasing the size of the image I do not see any other negative aspect of it.