K. Ryabitsev-Prime 🍁Here's a prototype of "b4 review" with a nicer textual ui. What do you think?
https://asciinema.org/a/776900
https://asciinema.org/a/776900
Marcos Paulo de Souza@monsieuricon Any ideas when this feature will be available? :)
@mpdesouza I just need to complete a few steps that would let maintainers "take" the series as opposed to just review it. Not far now, I just need to a) recover from being sick, b) stop dealing with failing hardware. ;)
@monsieuricon I'm currently reviewing a patchset by replying to each email, and I remembered that B4 would do it in a better way...
Thanks for the update!
Thanks for the update!
sj@mpdesouza @monsieuricon I guess you want to send all replies at once? Indeed 'hkml' has no good feature for such things. I do such kind of batched replying with below workaround.
After writing a reply, 'hkml' asks you if you really want to send it, or not. If you say no, 'hkml' will ask you if you want to save and tag it as 'drafts'. In the case, if you try to reply to the mail again, 'hkml' finds the draft reply and ask you if you want to continue writing the draft. You can also list all drafts using 'hkml list drafts' and continue writing it, using the menu.
So when I want to review all patches and then send all comments at once, I save my drafts for each patch, and iterate multiple times on each draft for adding more comments on the drafts. Once I think all replies are ready to go, I send those one by one, but with no more draft updates.
Maybe I can add a new hkml feature for sending all drafts for a given thread at once.
#hkml
After writing a reply, 'hkml' asks you if you really want to send it, or not. If you say no, 'hkml' will ask you if you want to save and tag it as 'drafts'. In the case, if you try to reply to the mail again, 'hkml' finds the draft reply and ask you if you want to continue writing the draft. You can also list all drafts using 'hkml list drafts' and continue writing it, using the menu.
So when I want to review all patches and then send all comments at once, I save my drafts for each patch, and iterate multiple times on each draft for adding more comments on the drafts. Once I think all replies are ready to go, I send those one by one, but with no more draft updates.
Maybe I can add a new hkml feature for sending all drafts for a given thread at once.
#hkml