Before AI, I felt like I could review PRs and, based on whose code I was reviewing, I could be more trusting and casual with my review, since I knew they usually wrote good code and paid attention to details. Now, with AI, no one pays attention to details, so I have to deeply scrutinize every PR, which takes twice or 3x the effort.
AI agents almost always add things that aren’t necessary, or they follow anti-patterns based on the surrounding legacy code context.
@ramsey Just let an AI do the review.
In all honesty:
* If you don't want to accept AI PRs, say so and reject all AI looking PRs without further looking at it.
* If you (have to/want to) accept AI PRs: Go full in and let the AI do the "review". REquest full documentation so that you can run End-To-End tests based on the requirements. Fuck all human based measurements that we used to hold up.
I don't think there is a sustainable way in between... 😕
@heiglandreas @ramsey This is becoming the norm at my workplace for folks that can bypass the "[Human] Review Required" check.
It is incredibly frustrating to watch so much slop go out the door. I'm no longer rubber stamping the PRs so instead they get someone else under them to Approve and out it goes. It's making me seriously consider withdrawing entirely in the next few months.
@heiglandreas @ramsey "Management wants" has become the dissolution of responsibility for everyone up and down the chain. 🥴
The rift between those who care and those who need a paycheck, that has long existed and has been getting worse the more money has been pumped into the industry, has been ripped wide open, and I suspect what we're going to see, or need to see, is the former gathering together at their own companies and projects while the latter ... 🤷♀️
Ben Ramsey
Alerta! Alerta!
Russell