Stefan EissingFeb 20

I waded in #curl rebasing pain with a bunch of stacked PRs yesterday. That was unfun and took the whole day.

Maybe I have not found the best way to handle stacked PRs with current git, yet.

Otoh, the colleague who changed variable names all over the code for fun and merged it without review is luckily working remote…😌

Show threadvszFeb 20
@icing My apologies, I guess it was the prototype/definition sync, which touched asyn* and hostip.c that collided?
Show threadStefan EissingFeb 20
@vsz Yes, especially renaming function parameters is nasty stuff. Naughty boy!😌
Show threadvszFeb 20
@icing Ah, sorry again. Those could have been postponed by just syncing the prototypes to the definitions, indeed.
Show threadStefan EissingFeb 20
@vsz It's always tempting to cleanup naming inconsistencies everywhere, but any open PR is potentially in trouble. Need to find a good time slot for it.
Show threadvsz
@icing Yeps. I try to avoid renaming things. This one slipped as part of a bunch of balls in the air while dealing with clang-tidy findings, and some tunnel vision to fix these more accurately.
Feb 20 at 12:07pmWeb