Michael Stapelberg 🐧🐹😺Feb 6

PSA: Did you know that it’s **unsafe** to put code diffs into your commit messages?

Like https://github.com/i3/i3/pull/6564 for example

Such diffs will be applied by patch(1) (also git-am(1)) as part of the code change!

This is how a sleep(1) made it into i3 4.25-2 in Debian unstable.

Show threadSimon Tatham

@zekjur not the first time: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1081179

But at least in my case it was pretty harmless, and the worst effect was that 'dgit clone' was unexpectedly slow (which is how I spotted it).

#1081179 - Example patch hunk from a commit message applied to package source - Debian Bug report logs

Feb 6 at 1:44pmWeb