KissakiNov 22

OpenAI Demo'd Fixing Issue #2472 Live. It's Still Open Months Later.

https://programming.dev/post/41153880

OpenAI Demo'd Fixing Issue #2472 Live. It's Still Open Months Later. - programming.dev

> During OpenAI’s GPT-5 launch event, they demoed the model’s ability to fix real bugs in production code. Live on stage. In their own repository. The kind of demo that makes CTOs reach for their credit cards and engineers nervously update their resumes. There’s just one small problem: the fix they promised to merge “right after the show” is still sitting there, unmerged, three and a half months later.

Show threadKissaki

The issue, presumably the PR (linked at the top of the issue because of reference).

Look at the code change. It gets inputs and loops over them and seems to do an in-place fixup. But the code indent is wrong, and it even changed the function definition of the unrelated next function. In Python, the indent-logic-significance language.

I assume they briefly showed the code on stage. Even then it should have been obvious to any developer. py file, messy indent, changes unrelated function.

Please correct me if this is the wrong PR.

Uploading PDF via Files API and using in Streaming gives 400 bad request · Issue #2472 · openai/openai-python

Confirm this is an issue with the Python library and not an underlying OpenAI API This is an issue with the Python library Describe the bug File "/Users/emdray/code/work/scoutos/services/big_boi/.v...

GitHub
Nov 22 at 8:33amWeb
Show threadthebeardedpotatoNov 22
Based on what they showed in the demo, that’s not the PR. gpt made more changes than what’s in that PR and also modified a different transform function. My guess is they never actually pushed the actual commit from the demo or made a PR.
Show threadKissakiNov 24
I see, thank you for the clarification. I was quite confused because it seemed to be missing, this one didn’t quite seem correct. If they never even pushed it as a MR then that makes more sense. Then the whole “hasn’t been merged yet” is missing that it hasn’t even been created.
Show threadZikejiNov 22

Does not appear to be the correct MR. Comments on the issue allude to “they never pushed it” so sounds like there never was an MR. Watching the announcement where they demo’d it, it wrote much more than is in that MR. Not to defend OpenAI, I hate vibe coded solutions that add so many useless comments.

Write. Readable. Code.

Show threadKissakiNov 24
I see, thank you for the clarification. I was quite confused because it seemed to be missing, this one didn’t quite seem correct. If they never even pushed it as a MR then that makes more sense. Then the whole “hasn’t been merged yet” is missing that it hasn’t even been created.
Show threadA_norny_mousseNov 22

The issue

What’s with the comments? “Hi mom”

the PR

So “LuminaX-alt” is an AI?

Show threadYoddel_HickoryNov 22
Actually the function definition is un changed. The line that was “added” as the bottom was also “removed” at the top. This is just the Git diff generator being confused, which won’t come as a surprise to anyone that has ever used it.
Show threadKissakiNov 24
An indentation change is a definition code change. And as I pointed out, it’s a py file, and Python is an indent-significant language.
Show threadYoddel_HickoryNov 24

Of course, but you said:

But the code indent is wrong, and it even changed the function definition of the unrelated next function.

It is weird to split the two in your sentence, as only the indentation of the next function definition was changed, not the definition itself.

You can just take the L and say you didn’t see that the function definition that was “added” was just “removed” at the top.It is an easy mistake to make, I know I’ve done it many times.

Show threadKissakiNov 25

You can just take the L and say you didn’t see that the function definition that was “added” was just “removed” at the top.

That’s not what happened though.

Changing the indent of the def changes the definition. That’s my whole argument.

I don’t get why you say “of course”, agreeing with my point, but then “it was only the indentation that was changed”.