Tim De JongFixed the build of GRDB on Linux and now trying to fix the failing tests. More than 400 tests are failing so it was difficult to see which tests were, but luckily I found:
Apart from some minor tests that probably fail because of Linux specific things, actually most failures are in the DatabasePoolConcurrencyTests. Need to see whether this also occurs on macOS, and if not see what's causing this on Linux #swift #swiftlang #linux #grdb #sqlite
Gwendal Roué@tjadejong Please do not hesitate submitting a pull request. The Linux build is contribution-based, and I do wish it is well-maintained, even if I personally lack the ability to check and test it.
@groue hi Gwendal, was planning to but not sure when is the correct moment. Solving all issues first or doing it bit by bit? What do you think? Could use some advice!
@tjadejong I wasn't expecting there were so many issues. Maybe we can start looking at the picture in a GitHub discussion, when you have time, and come up with a plan?
@groue sure! Let me make a summary and create a discussion. Will not have much time today but for sure in the coming days. Actually the most important issue was not a build error but a linker error as the linux library for sqlite doesn’t have WAL enabled. I have already used the patched library in some linux software before without problems btw, so I still hope these errors can be quickly fixed!
@groue I opened a new discussion here:
https://github.com/groue/GRDB.swift/discussions/1821
Will describe the changes in a couple of parts to make it more manageable to write/read.
@tjadejong Thanks for opening this detailed report! I'll look shortly at the compiler flags used by GRDB. Things are too complicated, and I'll try to make them more simple.
@groue you're welcome :D! I will look at what's the problem with the failing tests. Still will have to sync my fork with the main repo though...