HaileyJun 26

Sent a pull request to Audacity fixing a crash bug I'd been running into frequently. The cause was an out-of-bounds memmove. Classic C++ areas.

Anyway I got a fucking copilot review on my PR which left two comments, both completely wrong, one of which suggesting I reintroduce the out of bounds memory access. I'm furious!

Show threadHaileyJun 26
You know back in my day, we had static analysis tooling that would give you exactly this kind of feedback, except it was correct. Now we have shit which only looks at the vibes of the source text and does no semantic analysis whatsoever, so of course it's just fucking wrong
Show threadHaileyJun 26
I spent a couple of hours yesterday getting Audacity building, reproducing and diagnosing the bug, and wrapping my head around the complex logic in this part of the code so that I could implement a correct fix. To have copilot review my work, which I contributed back for free, is just so incredibly disrespectful to my time and effort.
Show threadTenacity Audio EditorJun 26

@hailey Not to self promo but we're working on rebasing off Audacity 3.7.4 (without the Muse stuff) and chances are we likely have this bug on our rebase branch. If you want to help us with our rebate efforts we'd be happy! No CLA and AI are involved too!

@gperson will be happy to help you with anything too. Just ask him and he'll help you out the best he can! (That's me writing this too. Hello 😄👋)

Show threadHaileyJun 27
@tenacity @gperson I had already planned to send this fix across! I wasn't aware of the muse drama or Tenacity until today but I'll be switching over going forward :)
Show threadkittenJun 28
@hailey @tenacity @gperson awawa lol i reported this many years back and got multiple patch ideas at the time https://github.com/audacity/audacity/issues/2930
Crash when scrolling spectrogram partially off-screen · Issue #2930 · audacity/audacity

Describe the bug When I switch a clip to spectrogram view and scroll it partly off-screen, it calls memmove with an out-of-bounds source (which crashes on Flatpak Audacity, and is invalid but uncau...

GitHub
Show threadGeneric Person6d ago
@nyanpasu64 @tenacity @hailey Oh you know what that was probably it and it's been finally fixed after all this time. Nice to know how that finally got fixed! 😄
Show threadkitten6d ago
@gperson @tenacity @hailey Now we simply wait for the AI-powered spectrogram view... but unironically neural networks are the current meta for audio source separation and possibly transcription.
Show threadGeneric Person6d ago

@nyanpasu64 @tenacity @hailey OH GOD 💀

I do acknowledge the power AI, however, especially for audio, but I'd prefer if it is run locally at least. I don't have anything with NPUs, however,so you won't see that coming from me ateast.

Oh, and your horizontal scrolling work on Tenacity's plot spectrum window was recently reapplied to the rebase branch. Only proof that your contribution will live on for years! 😄

Show threadGeneric Person
@nyanpasu64 @tenacity @hailey And about the NPU thing: I'm down to using a 10-year-old laptop as my main right now. Gotta worry about getting a newer one first, then I'll worry about NPUs 💀
Jun 29 at 4:11amWeb