Florian

Today in bugs I always hope to never run across: #Corruption of the save state of #minecraft worlds. Turns out, Thermal Series has (had?) a #bug, where machine upgrades don't mark the chunk they're in as modified; effectively voiding the upgrade item if directly exiting the world after applying it.

Aside: #Discord Channels are not a #BugTracker :( :( :( This took me far too long to uncover - it could have been a simple DuckDuckSearch away.

Dec 20, 2024 at 9:43pmWeb
Show threadFlorianDec 20, 2024
[21:54]LobsterJonn: pipez having issues, preposterous! :KEKW:
[21:55]Scarface96361: ok i dont think its specifically thermal. but even after putting the extractor back atop the pipe and setting it back up exactly how it had been previously i can no longer replicate the issue
[22:10]Random: it shouldn't be possible for a pipe mod to remove augments, they're not exposed to the capability
Show threadFlorianDec 20, 2024
[22:12]Scarface96361: hence why im very confused. the augments were just dissapearing. but after moving the extractor and putting it back the bug stopped happening and i cant get it to happen again anymore
[22:17]Random: :lemmingthink: where's setChanged? https://github.com/CoFH/ThermalFoundation/blob/HEAD/src/main/java/cofh/thermal/lib/tileentity/ThermalTileAugmentable.java#L841
Show threadFlorianDec 20, 2024
[22:18]Random: [honestly I could be missing something, this inventory handler code is a bit complex to navigate and i'm not that familiar with it, but I can't see what else could be making the required call to setChanged]
[22:33]Scarface96361: i dont know
[22:46]Random: anyway if my speculation is right, changing the augments didn't cause minecraft to realize the chunk needed to be saved, so if it was the last thing you did before you quit it's possible it didn't get sav
Show threadFlorianDec 20, 2024
[23:08]Scarface96361: that actually makes sense cause i think it was the last thing i did in that chunk originally.
[23:59]Dr Lemming: That’s what it is yeah. Generally this is never really a problem but I’ll be adjusting the save behavior a bit
Show threadFlorianDec 20, 2024

Luckily, this is easy to work around, if you know about it: simply place/destroy a block in the same chunk the machine is in. This will cause the chunk to get saved, including the machine upgrade.

This is lucky for two reasons:
1. Thanks to using Discord as a "Bug Tracker", I have no idea if this ever really got fixed, and if it did get fixed, which versions contain the fix.

2. I'm playing this mod as part of a larger modpack, updating the mod might not be so easy anyway.