Susannah SkyerIn case you're looking for something to do for the next hour, wanna help me figure out layout issues? I would like each dog image (of different sizes in the asset catalog) to appear the same size in the grid. I want to use all available screen space in the view on any device and also have the view look good when the device rotates. Will put view code and another screen (where the images happen to be the same size and thus look good) in the comments. TIA and happy WWDC!
I absolutely understand why this got no traction on Monday of WWDC week, but I would still love some help if anyone's up for it. Will be consulting robot pals later, but actual human pals are terrific too. ;)
Josh Hrach@SuzGupta I haven't tried this yet on my side, but I wonder if the flexible columns is the issue. If you test it with a constant value, do the images still look mismatched?
@SuzGupta Alternatively, if you change from a `.fill` to `.fit` in the aspect ratio modifier, does that help?
@JoshHrach If I use a constant value, aren’t I potentially messing things up for different device sizes and orientations?
@SuzGupta You are. I'm just suggesting it for testing. If a constant seems to provide the consistency you want, then the issue is with the columns. If the images still don't look right, then it might be the images/'cells’ themselves that are the issue.
I definitely wouldn't ship a constant column width.
@JoshHrach Thanks for explaining; I'll play around with it. I think the issue may be with both and I also know (sort of related) that some of the images should be cropped. Trying to strike a balance here between getting this done and done perfectly, well, at least "right".
@JoshHrach after spending way too long messing around with an unneeded GeometryReader, the solution ended up being adding this line on each Image `.aspectRatio(1, contentMode: .fit).`
@JoshHrach No GeometryReader, ViewThatFits, or size classes needed and it looks decent on iPhone and iPad, portrait and landscape. Whew!
@SuzGupta Glad you got it figured out!