lobo May 3, 2024
@meena is contribute with the https://github.com/scovl/checkrc #opensource project! Thanks Mina!     #freebsd
GitHub - scovl/checkrc: A command-line tool designed to validate the configuration settings in the FreeBSD /etc/rc.conf file

A command-line tool designed to validate the configuration settings in the FreeBSD /etc/rc.conf file - scovl/checkrc

GitHub
Show threadFelix Palmen 馃摨May 3, 2024

@lobocode @meena Regarding Mina's "make" commit, I'd have remarks 馃槈 :

- POSIX make is IMHO too limited to use for anything "non-trivial" in any other way than *generate* the makefiles with more powerful tools. For hand-written makefiles, GNU make isn't the worst choice when portability is a goal ... it's available on many platforms.

- I agree recording dependencies would make sense.

- Here we talk about a tool specifically for #FreeBSD. Does it make any sense to design the build in a "portable" way? If not, I'd suggest using FreeBSD's make (bmake) together with FreeBSD's make framework from /usr/share/mk ... this will simplify things a lot. I could create a PR doing that if you want.

Show threadlobo May 3, 2024
@zirias @meena I would be happy if you sent one PR with these questions, Palmen. 
Show threadFelix Palmen 馃摨

@lobocode @meena
PR created: https://github.com/scovl/checkrc/pull/5

Mina, no, not "just your headache", the portable subset of make simply doesn't cut it, and doing complex things in make is possible, but hard and quickly becomes unreadable, that's why well-written frameworks are a nice thing ...

I personally have my very own for #gmake (which I use for all portable stuff). When writing stuff specifically for #FreeBSD, I very much prefer using what's already there.

Makefile: Move to bmake using FreeBSD's framework by Zirias 路 Pull Request #5 路 scovl/checkrc

For a tool targeting specifically FreeBSD, we probably won't need a portable build. Using FreeBSD's make framework from /usr/share/mk gives us lots of things for free, for example: On-the-fly depe...

GitHub
May 3, 2024 at 5:48pmWeb
Show threadFelix Palmen 馃摨May 3, 2024

@lobocode @meena BTW, there are a few things you might want to change, but that's up to you to decide:

- I don't think you use any "newer" C features, so CSTD=c11 or maybe even CSTD=c99 might be enough

- -pedantic *can* cause issues, although it currently probably doesn't, you *might* want to remove it

- bsd.prog.mk defaults to building debugging info into a separate file and also install that. If you don't want that, you *might* want to add MK_DEBUG_FILES=no

Show threadFelix Palmen 馃摨May 4, 2024

@lobocode @meena Found another issue and created yet another PR for it:
https://github.com/scovl/checkrc/pull/7

Background is explained there, in a nutshell, avoid setting -Werror in the default CFLAGS (distributed to users), it has the potential to just break builds...

Instead take advantage of github's infrastructure and have a CI build run automatically on pushes and pull requests that *does* use -Werror.

Add a CI build by Zirias 路 Pull Request #7 路 scovl/checkrc

Add a CI build also running the result on FreeBSD 14.0 Enable warnings as errors (-Werror) in CI build, disable it in default CFLAGS (so an updated compiler won't break a "normal" build). Backgrou...

GitHub
Show threadlobo May 4, 2024
@zirias @meena CI did is something that I had planned as well. Ty
Show threadFelix Palmen 馃摨May 4, 2024

@lobocode @meena NP. You could now even get creative and e.g. add testcases (rc.conf files with different errors) in '.github' and script in the yaml file to check for the expected output or whatever.

But OTOH, I wouldn't invest TOO much work here either, because this part is strictly tied to github and services *they* offer (while a git repository itself is completely independent from where it is hosted).