jonny (good kind)Apr 1, 2024

Poetry continues its reputation as "the package manager that will tell you what you're doing is wrong and bad and you should feel bad for wanting to do very obvious things like show a diff of what was updated when you regenerate the lockfile"

https://github.com/python-poetry/poetry/issues/9259#issuecomment-2030668775

Add `poetry lock --diff` flag to show which packages were changed when locking · Issue #9259 · python-poetry/poetry

Issue Kind Brand new capability Description first of all THANKS to all y'all, really appreciate all the work that has gone into poetry, we use it all the time and love it. We have made an action to...

GitHub
Show threadDima TisnekApr 2, 2024
@jonny if `poetry.lock` is checked in, how about writing a diff tool that summarises the changes? That would come in handy, e.g. folks could plug it into their `on: pull-request` pipeline to highlight the changes at the pr review stage. Kinda similar how js can be unuglified or compiled translation file or image files. WDYT?
Show threadjonny (good kind)Apr 2, 2024

@dimaqq that's what I did!
https://github.com/linkml/linkml/pull/2044
which makes this
https://github.com/sneakers-the-rat/linkml/pull/6

(and one like comically rude poetry dev is telling me is pointless and i should feel bad about needing to work around a pretty obvious and easy missing feature in their cli tool)
https://github.com/python-poetry/poetry/issues/9259#issuecomment-2031238318

"the whole premise for this feature request and that other pull request collapses"

lmao

Automatically PR to update poetry lockfile v3 by sneakers-the-rat · Pull Request #2044 · linkml/linkml

Continues: #2028 Continues: #2023 OK I AM SO SORRY this has taken several PRs to get right - hopefully it's clear that i am not trying to be sloppy and these are problems caused by CI being weird a...

GitHub
Show threadDima Tisnek
@jonny I'm so sorry, I think that you misunderstood me. I was trying to propose that a separate, standalone utility and a github action could be made that shows lock file diffs. So that other developers can pull it into their PR workflows. In my mind, it would parse the lock file, rather than rely on `poetry show -t`. Arguably this could be generalised to other lock files: pdm/pip, npm/yarn, rust/go, etc. Perhaps it already exists!
Apr 2, 2024 at 11:08amWeb
Show threadjonny (good kind)Apr 2, 2024
@dimaqq
Well, I guess thats what I have proposed and drafted in that issue, we'll see if they go for it. Idk about different lockfile formats, theyre all sorta different, but its ultimately not more complicated than comparing added, removed, changed versions so ha could probably be done