Evan MartinOne cool bit in the xz exploit was this patch that subtly disabled the sandbox.
https://git.tukaani.org/?p=xz.git;a=commitdiff;h=328c52da8a2bbb81307644efdb58db2c422d9ba7
It's the 8th added line of the patch, making the compile check always fail.
dana 
@evmar wow. I could easily miss that.
@blinkygal I endorse https://difftastic.wilfred.me.uk/
@evmar stuck in gerrit :/ But this looks cool thanks
@blinkygal I set it up for 'git diff' locally (it's in the instructions)
@evmar I wish my workflow for reviewing changes was so different than it is now. A local app where I can read the change without all the website latency and jank, and where I can leave comments. Difftastic integration would be very nice.
I wonder how much work it would be to build it.
@blinkygal I vaguely recall hooking up a thing that would pull a rietveld change into a git branch so I could diff, test, modify etc. I bet gerrit can do it. GitHub has a URL on PRs that can be piped to git am.
@evmar yeah it’s all git, with gerrit, which is supposedly also why it’s so slow. and there are apis to put comments but I think they are only resolved ones right now. maybe the rust unsafe review tooling will get me what I need.
Daniel Cheng@evmar I thought that was neat as well! Though autoconf and friends generally just make me sad…