Tony BowdenHmm, @maxlath are the constant warnings I'm getting from wikibase-cli that punycode is deprecated something I can avoid by upgrading something somewhere? I don't know my way around the node ecosystem well enough to track down exactly where it's coming from.
maxlath@oravrattas when do you get those warnings? When installing? That shouldn't be an issue, but I will have a look
@maxlath I get them when running almost any command:
wd search "Douglas Adams"
(node:1800) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Lucas Werkmeister@oravrattas @maxlath FWIW I have those in m3api as well and IIRC tracked them down to https://github.com/lupomontero/psl/pull/298 (which is merged but not yet released, and then everyone will have to transitively update stuff to pull in the new version of whatever library that is)
chore(deps): Replaces deprecated Punycode provided by Node with punycode.js by lupomontero · Pull Request #298 · lupomontero/psl
Node's Punycode module has been deprecated for years as pointed out by @Macil in #296. This PR replaces the deprecated module with mathiasbynens/punycode.js as suggested.
@LucasWerkmeister @oravrattas in the case of wikibase-cli, it seems that it was caused by a dependency of eslint relying on punycode, so updating eslint seems to fix it https://github.com/maxlath/wikibase-cli/commit/fcb224b Patch published in v17.0.10
@maxlath @LucasWerkmeister I'm still getting the warning after updating to v17.0.10 :(
(node is at v21.5.0 FWIW)
@oravrattas @LucasWerkmeister ah yes, I messed up my node version and was too quick to call victory >< (it's indeed not happening with node 18)
@oravrattas @LucasWerkmeister new clue: it seems to be caused by whatwg-url, which is a dependency of node-fetch. Maybe I can just replace it with standard fetch, let's see
@oravrattas @LucasWerkmeister that seems to work, I published wikibase v18.0.0, which should hopefully now properly fix that issue 🤞
@maxlath @LucasWerkmeister I can't see v18 yet. Something gone awry somewhere?
@oravrattas @LucasWerkmeister yes 🤦 at test failed, preventing the publication. Now that should really work 😅
