Question about gdscript: Which is more efficient?

https://sopuli.xyz/post/4120489

Question about gdscript: Which is more efficient? - Sopuli

I’m just curious about which is the most efficient way of doing this (in a loop): o=[var1,var2,var3,varN][i] or match i: 0: o=var1 1: o=var2 2: o=var3 N-1: o=varN or var items = [var1,var2,var3,varN] for i in something(): o=items[i] Or is there a more efficient way of doing it?

If speed is actually important then I would consider writing it in another language looking for someone else’s implementation (personally). I try to focus on readability and doing the simplest implementation. I’ve been trying to use better function/variable names to explain what is happening at a glance instead of reading the whole thing. Have you considered using map for array iteration? I am hoping even if people don’t know how this work the intention is more readable than an equivalent for loop:

func _show_only_first_layer_dots(): var set_dots_visibility = func(layer): layer.get_node("Dots").visible = (layer == $Layers.get_child(0)) $Layers.get_children().map(set_dots_visibility)

I find that much harder to read than a for loop. You are making a helper function to only use it once, which is kind of confusing when it is totally unnecessary. Also, distinguishing between two groups only inside the setter line is weird. Applying the modification to one group, then the other, is more obvious. Considering the alternative isn’t really longer, and only using basic loop syntax, I would just use the loop. If you really want to add the “set dots visibility” explanation into it, just use a comment, that’s what they’re for.

I literally just now misunderstood your code and had to change my comment to correct for it.

You looked at how it works and made comments about that (which I am thankful for and will enjoy replying to below). Can I first bring your attention to what is does instead of how it does it. Do you think that the names of the method function and helper function made it’s intended result clear, or is a for loop clearer in that way too?

I shouldn’t have included the node.visible = (expression) in the example, that was needlessly complex. It’s just what was in front of me (I do however find it appealing because it reduces the number of lines but that is another discussion).

While for loops are a popular method taught to every programmer early on then a for loop is easier to understand step by step. I do find occasions where a for loop just looks better but I keep finding that I better understand what my code is actually doing when I try to write a loop using functional programming methods.