Dare ObasanjoAug 7, 2023
A broken clock fixed by taping a working clock over it is a metaphor for every codebase you’ll encounter in your professional career as a software developer.
Show threadEric G.

@carnage4life I have been occasionally scolded for my 'messy' PRs that muck out disfunction, realign ancillary internal methods & data structures and/or otherwise embrace my inner Fowler. The PR diffs are ugly AF but some of them are things I am most proud of.

To the topic: lately I feel sometimes our PR/user story approach encourages the employment of duck tape by encouraging change that fully satisfies stated requirements, makes for easy-to-read PRs, but loses the plot along the way.

Aug 8, 2023 at 12:04amWeb
Show threadPork SodaAug 9, 2023
@ericg @carnage4life yes! The attitude of “the best PR is the one that changes the fewest lines of code, and note an SCR for any refactoring you think is needed separately” was the predominant attitude on my team when I first joined. One look at the stack of minimum-priority refactoring SCRs going back over a decade tells you everything you need to know about how that was working for them. 🙃