@timbray oh my so, umm: a race condition, a mismatched parentheses, call by ref vs val, possible Unicode string .. only missing an off-by-one error for Yahtzee .
This is a very good write up and I wish we got more that are this candid.
@timbray Neatly described.
My only beef is the passage “all local accounts in a Mastodon instance have a null value in their URI field, so they all matched”. But null ≠ null, AccountMergingWorker isn’t matching correctly.
@timbray As much as I like the writeup, it again illustrates one issue I keep having with Devs as a Sysadmin: they rarely plan for scaling.
Running read queries against read-only replication targets that might have a delay is one of the best ways to increase performance, response times, and uptime, so it should be supported in some way.