Matt Glaman
Dependency injection anti-patterns in Drupal #drupal https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal?utm_campaign=blog&utm_source=fediverse&utm_medium=social&utm_content=toot
Dependency injection anti-patterns in Drupal

Whenever I have done an audit for a Drupal codebase, one of the first things I manually review and profile is dependency injection anti-patterns in custom code and any contributed modules used. The anti-pattern isn't for accessing services statically through \Drupal: service. These anti-patterns live within the class's __construct method.

mglaman.dev
May 23, 2023 at 1:18pmWeb
Show threadmatthieuMay 23, 2023
@mglaman i have all those 3 wrong !!! 😂
Show threadMatt GlamanMay 23, 2023
@matthieu honestly it's only really bad if you have absurd forms (see commerce checkout form) or inefficient event subscribers
Show threadmatthieuMay 23, 2023
@mglaman i feel better ty ^^ i will keep doing anti pattern then 😆
Show threadlarowlanMay 23, 2023
@matthieu @mglaman the entity storage one can be nasty. I've seen poisoning of the hook cache if you do that before modules are loaded (eg in an inbound or outbound path processor). Can have flow on effects like field module hooks not being called and therefore missing field definitions 😬