This is bad and [redacted] should feel bad:
```
<a aria-label="I need help. (Opens a pop up)." tabindex="0" role="link">
I need help
</a>
```

For those new to all the risks, here is a less broken approach:
```
<button aria-haspopup="dialog">
I need help
</button>
```

Granted, `aria-haspopup` announcement is meh (https://github.com/w3c/aria/issues/1024), but at least it is less broken.

For genuine links that *must* open in a new window (like a help assist), the correct approach is to put the text into the page itself for all users:
https://adrianroselli.com/2020/02/link-targets-and-3-2-5.html

Clarify usage of aria-haspopup · Issue #1024 · w3c/aria

Coming out of our discussion of #999 We should review aria-haspopup and determine if there should be stronger guidance about what the expectations are for when the attribute should be used, and wha...

GitHub
@aardrian Apart from it being dumb (redundancy, role duplication, using text rather than attributes) is there anything else I'm missing?
@sukiletxe Wrong role, wrong element to start, 1.3.5 risk, dialog warning only goes to SR users, specific event handlers must be coded, auto-translation risk.