@jgarber I used my static site generator to compile C files to .o files and link them, with proper #include dependency tracking and frankly I think incremental+live compilation would also work

Just saying this to encourage the chaos 😅

Seems like cl-electron knew about this issue and patched nan to remove this file. While I'm now able to build the "synchronous-sockets" node module, I still get into the situation where NODE_MODULE_VERSION mismatches.

"postinstall": "sed 's/^#include .nan_scriptorigin\\.h./\\/\\/ #include nan_scriptorigin.h/' ./node_modules/nan/nan.h > ./node_modules/nan/nan.h.new && mv ./node_modules/nan/nan.h.new ./node_modules/nan/nan.h && electron-builder install-app-deps",

Ref https://github.com/atlas-engineer/cl-electron/blob/master/package.json#L16

@dalias @khm The meaning never changed, it has always meant classic Mac OS or OS X(+derivatives). See TargetConditionals.h from 10.1: https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.1.5.sdk/usr/include/TargetConditionals.h

The bug is that zutil.h doesn’t include TargetConditionals.h, so TARGET_OS_MAC wasn’t defined on OS X until the Clang change.

(On Classic, TargetConditionals was probably pulled in through a precompiled or system header)

I agree Clang shouldn’t define these without a TC.h #include, but that ship sailed long ago:
https://github.com/llvm/llvm-project/pull/74676

@benbrown Now that would be my epitaph for my tombstone, coded in C:

// [my name here as an author]
// [my birthdate] - [my deathdate]

#include <stdio.h>

main() {
printf("Goodbye world!\n");
}