Property hooks is the first PHP feature where static analysis is a must. It's so easy to shoot yourself in the foot.
Here's a property with a set hook that does not actually assign value to the property which is suspicious.
PHPStan will report it as an error:
@OndrejMirtes At least for property hooks there is a reasonable expectation that the setter assigns to the backing store.
public function setK(int $value)
{
$this->j = $value;
}
would be the equivalent mistake without hooks, but would require checking the body against the method name to detect the mistake automatically.
@OndrejMirtes Nice!
Just make sure it isn't overly aggressive. Writing to another property from the set hook is totally reasonable. Having one virtual and one non-virtual hook, though, I agree I can't see as anything but an error.
@Crell Do you think I should report “this non-virtual property is never read in the get hook”? It’d be a bit more work.
The foundation for the set hook check was mostly there, thanks to (your favourite) uninitialized properties checks 😊
@OndrejMirtes Nice!
Cc @ilutov in case he has thoughts on this thread.
Dominic Luidold
Ondřej Mirtes
Stephan Hochdörfer
Tim Düsterhus
Larry Garfield