#ciCD deploys PRs to test envs, #playwright running in #githubActions runs full #e2e #tests on all currently implemented functions of the application
New PRs must contain additional functional test, or point to existing tests that cover the current functionality
Formatting issues are never discussed in #codereview; just #eslint rules. #prettier is a given here.
No fighting about this either; everyone on the project votes, and the most popular rule setting wins and everyone moves on.
ideally, there is a Test Engineer or QA team that can either write the functional tests, or confirm that those being referred to are legitimate and sufficient.
It's just important that when something is a barrier between your feature code and shipping there should be someone responsible for helping the team keep it green.
#testEngineering #softwareEngineering #testEngineer #automatedTests #softwareTesting #testing #tests #software